Optimisations for node validity and neighbour filtering#2586
Open
ljeub-pometry wants to merge 44 commits intodb_v4from
Open
Optimisations for node validity and neighbour filtering#2586ljeub-pometry wants to merge 44 commits intodb_v4from
ljeub-pometry wants to merge 44 commits intodb_v4from
Conversation
fixing last compile error track count temporal edges
…e the edge ref already
… edges are not the same
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: eb2a498 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
127 ns/iter (± 33) |
1 ns/iter (± 0) |
127 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_window_100/num_edges |
21 ns/iter (± 1) |
8 ns/iter (± 0) |
2.63 |
lotr_graph_window_100/num_nodes |
142 ns/iter (± 35) |
5 ns/iter (± 0) |
28.40 |
lotr_graph_window_10/has_node_existing |
142 ns/iter (± 6) |
62 ns/iter (± 11) |
2.29 |
lotr_graph_window_10/iterate nodes |
36685 ns/iter (± 67) |
11339 ns/iter (± 40) |
3.24 |
lotr_graph_window_10/iterate edges |
98757 ns/iter (± 130) |
48684 ns/iter (± 211) |
2.03 |
lotr_graph_subgraph_10pc/num_nodes |
124 ns/iter (± 28) |
4 ns/iter (± 0) |
31 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
148 ns/iter (± 6) |
62 ns/iter (± 14) |
2.39 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
5098 ns/iter (± 101) |
1365 ns/iter (± 3) |
3.73 |
lotr_graph_window_50_layered/num_edges_temporal |
150884 ns/iter (± 3080) |
70121 ns/iter (± 7586) |
2.15 |
lotr_graph_window_50_layered/num_nodes |
65753 ns/iter (± 857) |
21435 ns/iter (± 536) |
3.07 |
lotr_graph_window_50_layered/has_node_existing |
923 ns/iter (± 107) |
129 ns/iter (± 12) |
7.16 |
lotr_graph_window_50_layered/max_id |
72923 ns/iter (± 1816) |
25556 ns/iter (± 252) |
2.85 |
lotr_graph_window_50_layered/iterate nodes |
148686 ns/iter (± 627) |
19308 ns/iter (± 47) |
7.70 |
lotr_graph_window_50_layered/iterate edges |
189223 ns/iter (± 668) |
83616 ns/iter (± 1318) |
2.26 |
lotr_graph_window_50_layered/graph_latest |
108249 ns/iter (± 2265) |
36649 ns/iter (± 916) |
2.95 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
603933 ns/iter (± 11495) |
192686 ns/iter (± 1569) |
3.13 |
lotr_graph_persistent_window_50_layered/num_nodes |
80435 ns/iter (± 1381) |
31517 ns/iter (± 779) |
2.55 |
lotr_graph_persistent_window_50_layered/has_node_existing |
1151 ns/iter (± 173) |
174 ns/iter (± 83) |
6.61 |
lotr_graph_persistent_window_50_layered/max_id |
89158 ns/iter (± 1329) |
38024 ns/iter (± 490) |
2.34 |
lotr_graph_persistent_window_50_layered/iterate nodes |
184429 ns/iter (± 755) |
35886 ns/iter (± 191) |
5.14 |
lotr_graph_persistent_window_50_layered/iterate edges |
171877 ns/iter (± 711) |
84161 ns/iter (± 596) |
2.04 |
lotr_graph_persistent_window_50_layered/graph_latest |
152348 ns/iter (± 4835) |
57549 ns/iter (± 4809) |
2.65 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
12097030 ns/iter (± 119763) |
5298035 ns/iter (± 147912) |
2.28 |
lotr_graph/proto_encode |
5935020 ns/iter (± 77966) |
1157897 ns/iter (± 73709) |
5.13 |
This comment was automatically generated by workflow using github-action-benchmark.
…onents algorithm (maybe can be optimised but at least it seems correct)
…hese should be cheap to look up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the implementations of node_valid and use src/dst from edge ref for filtering when available
Why are the changes needed?
Performance
Does this PR introduce any user-facing change? If yes is this documented?
No